Closed
Bug 1460726
Opened 7 years ago
Closed 6 years ago
comm-esr52 build busted - problem confirming the ssl certificate ... tlsv1 alert protocol version
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
Thunderbird 52.0
People
(Reporter: wsmwk, Assigned: tomprince)
References
()
Details
Attachments
(2 files)
Per Jorg, https://treeherder.mozilla.org/#/jobs?repo=comm-esr52
Thed error is: Could not fetch URL https://pypi.python.org/simple/blessings/: There was a problem confirming the ssl certificate: [Errno 1] _ssl.c:510: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version - skipping
bug 1286358?
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 2•7 years ago
|
||
Callek wsmwk: well, at least `Collecting blessings>=1.3 (from mozlog==3.4)` so mozlog requires blessings...
Callek and it looks like its build system at first glance
Callek wsmwk https://dxr.mozilla.org/comm-esr52/source/mail/test/resources/installmozmill.py#87
Callek wsmwk: sooo, I think this is fallout from pypi no longer letting us use old TLS...
Callek wsmwk: a workaround (not sure if its the best one) would be to vendor blessings into comm-esr52 and make that file installs it from the vendored local location
Flags: needinfo?(kmoir)
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8975529 [details]
Bug 1460726: Install packages from internal pypi mirror.
Philipp Kewisch [:Fallen] has approved the revision.
https://phabricator.services.mozilla.com/D1276
Attachment #8975529 -
Flags: review+
Updated•7 years ago
|
Assignee: nobody → mozilla
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8975529 [details]
Bug 1460726: Install packages from internal pypi mirror.
This is causing tests to fail.
Attachment #8975529 -
Flags: approval-comm-esr52?
Updated•7 years ago
|
Attachment #8975529 -
Flags: approval-comm-esr52? → approval-comm-esr52+
Comment 6•7 years ago
|
||
Only for TB 52 or also 62 and 61 (beta)?
Assignee | ||
Comment 7•7 years ago
|
||
We should consider something like this for comm-beta/comm-central, but they have diverged enough that this patch doesn't apply.
Reporter | ||
Comment 8•7 years ago
|
||
Tom or Philipp, can you land this please? (Jorg is not set up to land from Phabricator.
THanks
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Comment 9•7 years ago
|
||
I don't have a comm-esr52 tree ready for landing. Here is all you need to do:
hg import https://phabricator.services.mozilla.com/D1276?download=true
hg push
Flags: needinfo?(philipp)
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(mozilla)
Comment 10•7 years ago
|
||
(In reply to Philipp Kewisch [:Fallen] from comment #9)
> hg import https://phabricator.services.mozilla.com/D1276?download=true
That's only part of the deal. That doesn't give a commit message and the patch author is wrong, too.
So one needs to follow up with:
hg commit --amend --user "Tom Prince <mozilla@hocat.ca>"
Landed as:
https://hg.mozilla.org/releases/comm-esr52/rev/48295e2bf1df191ef4ec3010d496030ea8164730
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Version: Trunk → 52 Branch
Comment 11•7 years ago
|
||
That killed the Mac build which was previously working.
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Comment 12•7 years ago
|
||
Sorry, that busted all builds :-(
Comment 13•7 years ago
|
||
Untested, but based on the error message this should take care.
Flags: needinfo?(philipp)
Attachment #8975838 -
Flags: review?(mozilla)
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8975838 [details]
Fix - v2
`envion` is misspelled (missing an `r`).
Flags: needinfo?(mozilla)
Attachment #8975838 -
Flags: review?(mozilla) → review-
Comment 15•7 years ago
|
||
https://hg.mozilla.org/releases/comm-esr52/rev/835aa204b328f062d2b315b2a42b1dbb8d380b30
Not sure whether it needed the .get.
Assignee | ||
Comment 16•7 years ago
|
||
It doesn't in automation. People running it locally might run into problems without it. But that should be enough for us to go-to-build with.
Comment 17•7 years ago
|
||
https://hg.mozilla.org/releases/comm-esr52/rev/2039414ea21c481e1419a7040e3f5202072247c9
Add .get now. Third time lucky?
Comment 18•7 years ago
|
||
(In reply to Tom Prince [:tomprince] from comment #16)
> It doesn't in automation.
Well, if it doesn't then there's something else wrong:
AttributeError: _Environ instance has no __call__ method
I'm happy for the experts to fix this instead of me doing it by try and error :-(
Assignee | ||
Comment 19•7 years ago
|
||
Gah, I had s/()/[]/ in my original patch. But doing `.get` is reasonable.
Comment 20•7 years ago
|
||
Still
Could not fetch URL https://pypi.python.org/simple/blessings/: There was a problem confirming the ssl certificate: [Errno 1] _ssl.c:510: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version - skipping
You want to try with brackets instead of parenthesis and drop the .get? Then spell out the line here.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•7 years ago
|
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Assignee | ||
Comment 21•7 years ago
|
||
Looks like builds are running now:
https://hg.mozilla.org/releases/comm-esr52/rev/39a9f1a0d89b144248a7583029fc2d00db59bf01
https://hg.mozilla.org/releases/comm-esr52/rev/3112e25f905d0423f6f433a385f8c015a254c1e9
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Comment 22•7 years ago
|
||
Somehow there is no test coverage :-(
Assignee | ||
Comment 23•6 years ago
|
||
esr52 in all its incarnations is dead
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•